RFR: 8317697: refactor-encapsulate x86 VM_Version::CpuidInfo [v3]

David Holmes dholmes at openjdk.org
Thu Oct 26 03:21:32 UTC 2023


On Wed, 25 Oct 2023 12:47:47 GMT, Jan Kratochvil <jkratochvil at openjdk.org> wrote:

>> In OpenJDK project CRaC I had a [need to fetch new CpuidInfo without affecting the existing one](https://github.com/openjdk/crac/commit/ed4ad9ba31b77732dcede2eb743b2f389ec9a0fe#diff-6ed856c57ddbe33e49883adb7c52ec51ed377e5f697dfd6d8bea505a97bfc5a5R2743).
>> Which led me to encapsulate the object more and I think this no-functionality-change patch is even appropriate for JDK.
>> I am sure interested primarily to reduce the CRaC patchset boilerplate.
>
> Jan Kratochvil has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove the automatic zero-initialization

Okay this basic refactoring seems simpler/clearer to me. Thanks.

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16093#pullrequestreview-1698654611


More information about the hotspot-dev mailing list