RFR: 8318723: RISC-V: C2 UDivL [v2]

Hamlin Li mli at openjdk.org
Thu Oct 26 09:06:32 UTC 2023


On Wed, 25 Oct 2023 17:53:15 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> Ok, so let's keep the version with branch. You should add a comment at https://github.com/openjdk/jdk/pull/16346/files#diff-7a5c3ed05b6f3f06ed1c59f5fc2a14ec566a6a5bd1d09606115767daa99115bdR2435 explaining just that.
>
> But you're putting a conditional branch in the way of the common cases, and you're greatly increasing icache pressure, for the sake of a rare case. How does that make any sense?

Thanks @theRealAph @merykitty for the comments, I agree with you.
Have used the divu instead of introducing a cond branch here. And we will consider the regression of negative (also mixed) test cases as rare case, so just make sure the common case (positve one) get optimized.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16346#discussion_r1372829871


More information about the hotspot-dev mailing list