RFR: 8318723: RISC-V: C2 UDivL [v2]

Hamlin Li mli at openjdk.org
Thu Oct 26 10:13:49 UTC 2023


On Thu, 26 Oct 2023 10:04:56 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   use divu instead of quick path opt; use explicit param for is_signed instead of default value(true)
>
> src/hotspot/cpu/riscv/riscv.ad line 6736:
> 
>> 6734:     "and  $dst, $dst, $src1\n\t"
>> 6735:     "srli $dst, $dst, 63\n\t"
>> 6736:     "Ldone:\t#@UdivL"
> 
> You might want to update this part to reflect the latest changes.

Thanks for catching it. Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16346#discussion_r1372921549


More information about the hotspot-dev mailing list