RFR: 8306561: Possible out of bounds access in print_pointer_information [v5]

[Thomas Stuefe]

On Fri, 27 Oct 2023 22:50:50 GMT, Dean Long <dlong at openjdk.org> wrote:

>> Thomas Obermeier has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update mallocHeader.inline.hpp - revert obsolete copyright change
>
> src/hotspot/share/nmt/mallocTracker.cpp line 215:
> 
>> 213:     for (; here >= end; here -= smallest_possible_alignment) {
>> 214:       // JDK-8306561: cast to a MallocHeader needs to guarantee it can reside in readable memory
>> 215:       if (!os::is_readable_pointer(here) || !os::is_readable_pointer(here + sizeof(MallocHeader) - 1)) {
> 
> Would os::is_readable_range be the better choice here?

That would work too.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16381#discussion_r1375182306