RFR: 8301997: Move method resolution information out of the cpCache [v5]

Andrew Dinn adinn at openjdk.org
Mon Oct 30 08:29:45 UTC 2023


On Wed, 18 Oct 2023 07:36:49 GMT, Andrew Dinn <adinn at openjdk.org> wrote:

>> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Coleen and Fei comments
>
> src/hotspot/share/interpreter/bytecodeTracer.cpp line 527:
> 
>> 525:           assert(is_linked(), "invokehandle is only in rewritten methods");
>> 526:           assert(cpcache_index >= 0, "must be");
>> 527:           print_field_or_method(cp_index, st);
> 
> I don't understand this code very well but it looks like this change means `print_field_or_method` gets called twice when we have an `invokehandle` bytecode, passing `cp_index` both times. Is that intended?

This comment is still left to address, Matias.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15455#discussion_r1375838835


More information about the hotspot-dev mailing list