RFR: 8304939: os::win32::exit_process_or_thread should be marked noreturn [v5]

Julian Waters jwaters at openjdk.org
Mon Oct 30 10:44:31 UTC 2023


On Mon, 30 Oct 2023 09:32:19 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

> To speed along the process, I'm approving this even though I still want the pointless forward declaration of `thread_native_entry` removed. I'll trust you to do that without needing a re-review by me.

I'll do just that, but I have a couple of questions: What about the comment accompanying the declaration? And is os::infinite_sleep appropriate for this purpose? I couldn't seem to find anything else to make exit_process_or_thread nor raise_fail_fast noreturn qualified

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16303#issuecomment-1784917115


More information about the hotspot-dev mailing list