RFR: 8304939: os::win32::exit_process_or_thread should be marked noreturn [v3]

[Julian Waters]

On Fri, 27 Oct 2023 04:24:54 GMT, David Holmes <dholmes at openjdk.org> wrote:

> > I figured that a little refactoring of scope (from os::win32 to os_windows.cpp file scope) could help here
> 
> The very loose, not well followed, historical convention here is that the Windows specific os class contains the methods defined by os.hpp, while the implementation details go into the os::win32 class. In many cases the choice is somewhat arbitrary, but there should still be a good reason to move something around. Unnecessary refactoring just makes the PR harder to understand.

Just noticed something in this review comment - I didn't move the method into the os class, I moved it into os_windows.cpp file scope

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16303#issuecomment-1785173490