RFR: 8318694: [JVMCI] disable can_call_java in most contexts for libjvmci compiler threads [v6]

Tue Oct 31 14:27:37 UTC 2023

On Tue, 31 Oct 2023 14:07:51 GMT, Tom Rodriguez <never at openjdk.org> wrote:

> Should we convert any assert only can_call_java checks into guarantees?

Makes sense to me. There are only 3 such assertions and none of them are on performance critical paths:
* https://github.com/openjdk/jdk/blob/3e39d7b34cb310343a34adddc06bf1aaf4cacfb1/src/hotspot/share/classfile/systemDictionary.cpp#L614
* https://github.com/openjdk/jdk/blob/3e39d7b34cb310343a34adddc06bf1aaf4cacfb1/src/hotspot/share/classfile/systemDictionary.cpp#L2059
* https://github.com/openjdk/jdk/blob/3e39d7b34cb310343a34adddc06bf1aaf4cacfb1/src/hotspot/share/prims/upcallLinker.cpp#L82

What do you think @dholmes-ora @vnkozlov ?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16383#issuecomment-1787325023