RFR: 8319117: GrowableArray: Allow for custom initializer instead of copy constructor [v2]

[Kim Barrett]

On Tue, 31 Oct 2023 12:21:00 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> Johan Sjölen has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Use variadic templates for in-place construction
>>  - Two tests
>
> src/hotspot/share/memory/allocation.hpp line 500:
> 
>> 498:     return ptr;
>> 499:   }
>> 500: 
> 
> This should probably be a separate RFE.

I think this change should not be made.  Callers should be using global placement new.  That's what we
do everywhere else this comes up.  (It has always seemed like a bug to me that the operation "global
placement new" is syntactically an allocation function, and so subject to this kind of name lookup
collision, when it doesn't allocate.)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16409#discussion_r1377677915