RFR: 8318982: improve Exceptions::special_exception [v2]

Tue Oct 31 19:31:57 UTC 2023

On Tue, 31 Oct 2023 17:46:16 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> src/hotspot/share/utilities/exceptions.cpp line 111:
>> 
>>> 109: #endif // ASSERT
>>> 110: 
>>> 111:   if (!thread->can_call_java()) {
>> 
>> If this method was called from `Exceptions::_throw`, a log message will have already been emitted. I think the duplication is acceptable for these special exceptions.
>
> Yes, seems fine.
> 
> This code might need a local ResourceMark.

Good point: https://github.com/openjdk/jdk/pull/16401/commits/f74fa5ee688558db5917dd2951ced3786410b7fe

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16401#discussion_r1378074316