RFR: 8301997: Move method resolution information out of the cpCache [v6]

[Matias Saavedra Silva]

On Tue, 31 Oct 2023 14:44:43 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> Matias Saavedra Silva has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 10 commits:
>> 
>>  - Merge branch 'master' into method_entry_8301997
>>  - Removed flag arg from prepare_invoke on aarch
>>  - Fixed bytecode tracer
>>  - Coleen and Fei comments
>>  - Merge branch 'master' into method_entry_8301997
>>  - Added asserts for getters and fixed printing
>>  - Removed dead code in interpreters
>>  - Removed unused structures, improved set_method_handle and appendix_if_resolved
>>  - Removed some comments and relocated code
>>  - 8301997: Move method resolution information out of the cpCache
>
> src/hotspot/cpu/aarch64/templateTable_aarch64.cpp line 2374:
> 
>> 2372: 
>> 2373:   // setup registers
>> 2374:   const Register index = r4;
> 
> Hardcoding is not very nice. Maybe reuse one of the other registers?

This exists in x86 as well in each of the `load_resolved_method_entry_...()` methods. Some of these only have three arguments which cannot be reused so there is the option to include `index` as an argument, but this introduces an inconsistency among these similar methods. 

Should all of these methods take `index` which can be a reused register?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15455#discussion_r1378232141