RFR: 8313202: MutexLocker should disallow null Mutexes [v5]

Aleksey Shipilev shade at openjdk.org
Mon Sep 4 07:31:46 UTC 2023


On Sun, 3 Sep 2023 13:47:09 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:
>> 
>>  - Merge branch 'master' into JDK-8313202-mutexlocker-nulls
>>  - Merge branch 'master' into JDK-8313202-mutexlocker-nulls
>>  - Accept one more potentially nullptr mutex
>>  - Merge branch 'master' into JDK-8313202-mutexlocker-nulls
>>  - Replace ReentrantMutexLocker with ConditionalMutexLocker
>>  - Workaround for JDK-8313210
>>  - Fixing CodeCache analytics
>>  - Initial work
>
> src/hotspot/share/classfile/classLoader.cpp line 941:
> 
>> 939: 
>> 940: void ClassLoader::release_load_zip_library() {
>> 941:   ConditionalMutexLocker locker(Zip_lock, Zip_lock != nullptr, Monitor::_no_safepoint_check_flag);
> 
> Why is this one now `ConditionalMutexLocker`?

This one we know about: https://bugs.openjdk.org/browse/JDK-8313210

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15043#discussion_r1314541152


More information about the hotspot-dev mailing list