RFR: 8315149: Add hsperf counters for CPU time of internal GC threads [v2]
Man Cao
manc at openjdk.org
Tue Sep 5 23:16:41 UTC 2023
On Thu, 31 Aug 2023 05:55:35 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Jonathan Joo has updated the pull request incrementally with one additional commit since the last revision:
>>
>> address dholmes@ comments
>
> src/hotspot/share/gc/shared/stringdedup/stringDedupThread.hpp line 44:
>
>> 42:
>> 43: // Perf data for CPU time consumed by the string dedup thread.
>> 44: static PerfVariable* _g1_concurrent_dedup_thread_cpu_time;
>
> This variable seems unused. ??
It's better to move this variable to stringDedupProcessor.hpp/cpp. Then it will be updated in `StringDedup::Processor::run()`.
Also, we should rename this variable so it is not specific to G1. Shenandoah also supports string dedup (https://bugs.openjdk.org/browse/JDK-8203641).
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15082#discussion_r1316505698
More information about the hotspot-dev
mailing list