RFR: 8292692: Move MethodCounters inline functions out of method.hpp [v2]
Matias Saavedra Silva
matsaave at openjdk.org
Thu Sep 7 12:53:24 UTC 2023
> The inline functions related to MethodCounters in method.hpp can be moved to the inline file to reduce the number of includes. Verified with tier 1-5 tests.
>
> Below is a comparison of the old and new include statistics:
>
> Old
> ----
> scanning 836 methodCounters.hpp
> 2 found 836 method.hpp
>
> scanning 837 invocationCounter.hpp
> 2 found 836 method.hpp
> 3 found 836 methodCounters.hpp
> 4 found 649 interp_masm_x86.hpp
> 5 found 0 interp_masm_aarch64.hpp
> 6 found 0 interp_masm_arm.hpp
> 7 found 0 interp_masm_ppc.hpp
> 8 found 0 interp_masm_riscv.hpp
> 9 found 0 interp_masm_s390.hpp
> 10 found 0 interp_masm_zero.hpp
>
> scanning 298 method.inline.hpp
> 2 found 286 continuationEntry_x86.inline.hpp
> 3 found 0 continuationEntry_aarch64.inline.hpp
> 4 found 0 continuationEntry_ppc.inline.hpp
> 5 found 0 continuationEntry_riscv.inline.hpp
>
>
>
> New
> -----
> scanning 304 methodCounters.hpp
> 2 found 299 method.inline.hpp
>
> scanning 476 invocationCounter.hpp
> 2 found 304 methodCounters.hpp
> 3 found 257 methodData.hpp
> 4 found 0 interp_masm_aarch64.hpp
> 5 found 0 interp_masm_ppc.hpp
> 6 found 0 interp_masm_riscv.hpp
> 7 found 0 interp_masm_s390.hpp
> 8 found 0 interp_masm_zero.hpp
>
> scanning 299 method.inline.hpp
> 2 found 286 continuationEntry_x86.inline.hpp
> 3 found 0 continuationEntry_aarch64.inline.hpp
> 4 found 0 continuationEntry_ppc.inline.hpp
> 5 found 0 continuationEntry_riscv.inline.hpp
Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
Calvin comment
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/15094/files
- new: https://git.openjdk.org/jdk/pull/15094/files/dcffac79..e1ba0319
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=15094&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=15094&range=00-01
Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
Patch: https://git.openjdk.org/jdk/pull/15094.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/15094/head:pull/15094
PR: https://git.openjdk.org/jdk/pull/15094
More information about the hotspot-dev
mailing list