RFR: 8312174: missing JVMTI events from vthreads parked during JVMTI attach [v2]

Serguei Spitsyn sspitsyn at openjdk.org
Sat Sep 9 01:23:42 UTC 2023


On Wed, 6 Sep 2023 20:32:03 GMT, Alex Menkov <amenkov at openjdk.org> wrote:

>> Serguei Spitsyn has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
>> 
>>  - Merge
>>  - 8312174: missing JVMTI events from vthreads parked during JVMTI attach
>
> test/hotspot/jtreg/serviceability/jvmti/vthread/VThreadEventTest/libVThreadEventTest.cpp line 37:
> 
>> 35: 
>> 36: namespace {
>> 37:   std::mutex lock;
> 
> This mutex is only to make access to counters atomic.
> It would be clearer to make counters std::atomic<int> and remove the mutex

Good suggestion, thanks. Fixed now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15467#discussion_r1320450060


More information about the hotspot-dev mailing list