RFR: 8313202: MutexLocker should disallow null Mutexes [v8]

[Aleksey Shipilev]

On Tue, 12 Sep 2023 11:46:35 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> As seen in [JDK-8313081](https://bugs.openjdk.org/browse/JDK-8313081), it is fairly easy to pass nullptr `Mutex` to `MutexLocker` by accident, which would just silently avoid the lock.
>> 
>> There are a few places in Hotspot where we pass `nullptr` to simulate re-entrancy and/or conditionally take the lock. Those places can be more explicit, and the default `MutexLocker` can disallow nullptrs for extra safety.
>> 
>> More thorough testing with different GC/JIT combinations is running now, we might find more issues there. Meanwhile, please comment on the approach.
>> 
>> Additional testing:
>>  - [x] `grep -R "MutexLocker " src/hotspot | grep -i null`, only new `ConditionalMutexLocker` hits
>>  - [x] `grep -R "MutexLocker " src/hotspot | grep -i ?`, no hits
>>  - [x] Linux AArch64 fastdebug, `tier1 tier2 tier3` x `Serial Parallel G1 Shenandoah`
>
> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 14 additional commits since the last revision:
> 
>  - Merge branch 'master' into JDK-8313202-mutexlocker-nulls
>  - Touchup whitespace
>  - Rewrite jvmtiManageCapabilities lock usage
>  - Re-instate old asserts
>  - Merge branch 'master' into JDK-8313202-mutexlocker-nulls
>  - Merge branch 'master' into JDK-8313202-mutexlocker-nulls
>  - Merge branch 'master' into JDK-8313202-mutexlocker-nulls
>  - Merge branch 'master' into JDK-8313202-mutexlocker-nulls
>  - Accept one more potentially nullptr mutex
>  - Merge branch 'master' into JDK-8313202-mutexlocker-nulls
>  - ... and 4 more: https://git.openjdk.org/jdk/compare/6cf662c5...e3da7697

All right, let me integrate today. We would have the rest of the week to figure out if anything else is broken.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15043#issuecomment-1717095982