RFR: 8315415: OutputAnalyzer.shouldMatchByLine() fails in some cases

Leonid Mesnik lmesnik at openjdk.org
Thu Sep 14 20:06:54 UTC 2023


OutputAnalyzer.shouldMatchByLine(from, to, pattern) 
treat from and to parameters as patterns and not lines. So it might fail to compile them or work not as expected in some cases.

I grepped the usage of shouldMatchByLine and stdoutShouldMatchByLine and found that in most cases from/to are set to some regex patterns. So I just updated the names of variables and documentation to explicitly say that from/to are patterns.

See bugs for details. Tested with tier1 (mostly for validation scripts since no code changes.)

-------------

Commit messages:
 - 8315415

Changes: https://git.openjdk.org/jdk/pull/15753/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15753&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8315415
  Stats: 28 lines in 1 file changed: 0 ins; 0 del; 28 mod
  Patch: https://git.openjdk.org/jdk/pull/15753.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/15753/head:pull/15753

PR: https://git.openjdk.org/jdk/pull/15753


More information about the hotspot-dev mailing list