RFR: 8287325: AArch64: fix virtual threads with -XX:UseBranchProtection=pac-ret [v8]
Hao Sun
haosun at openjdk.org
Fri Sep 15 06:12:44 UTC 2023
On Thu, 14 Sep 2023 08:53:17 GMT, Andrew Haley <aph at openjdk.org> wrote:
>> Thanks for your suggestion. Updated in the latest commit.
>>
>> Note that `#ifdef ASSERT` is added in my commit, since variables `_empty` and `_orig_chunk_sp` belong to that scope.
>
> Please find some other extremely long lines in this patch. One is 138 characters long! Anything much more than 80 is a candidate for attention. It's very hard to read. And please don't use empty comment strings in assertions.
> All of this is about code readability.
Thanks for pointing this out.
Updated in the latest commit. Hope the code readability is improved now.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13322#discussion_r1326840329
More information about the hotspot-dev
mailing list