RFR: 8315954: getArgumentValues002.java fails on Graal [v2]

Doug Simon dnsimon at openjdk.org
Fri Sep 15 14:01:19 UTC 2023


On Wed, 13 Sep 2023 17:06:23 GMT, Tom Rodriguez <never at openjdk.org> wrote:

>> src/hotspot/share/interpreter/oopMapCache.cpp line 204:
>> 
>>> 202: void InterpreterOopMap::initialize() {
>>> 203:   _method    = nullptr;
>>> 204:   _mask_size = INT_MAX;  // This value should cause a failure quickly
>> 
>> Unless I'm mistaken, `USHRT_MAX` is a legal (but unlikely) value (i.e. `max_locals` in a class file can be 65635) so I changed this to use `INT_MAX` instead.
>
> It's actually not legal since _mask_size is always a multiple of `bits_per_entry` which is 2 so any odd value would work.  I would be leery of touching this unless you really need to.

Ok, I'll revert it to `USHRT_MAX`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15705#discussion_r1324862209


More information about the hotspot-dev mailing list