RFR: 8316180: Thread-local backoff for secondary_super_cache updates

Aleksey Shipilev shade at openjdk.org
Fri Sep 15 17:01:14 UTC 2023


Work in progress, submitting for broader attention.

See more details in the bug and related issues.

This is the attempt to mitigate [JDK-8180450](https://bugs.openjdk.org/browse/JDK-8180450), while the more complex fix that would obviate the need for `secondary_super_cache` is being worked out. The goal for this fix is to improve performance in pathological cases, while keeping non-pathological cases out of extra risk, *and* staying simple enough and reliable for backports to currently supported JDK releases.

This implements the mitigation for AArch64 and x86_64. More platforms can be implemented in this PR, or deferred to later PRs. Port maintainers, feel free to suggest the patches for your arches, I'll be happy to fold them in.

Note that the code is supposed to be rather compact, because it is inlined in generated code. That is why, for example, we cannot easily do x86_32 version: we need a thread, so the easiest way would be to call into VM. But we cannot that easily: the code blowout would make some forward branches in external code non-short. I think we we cannot implement this mitigation on some architectures, so be it, it would be a sensible tradeoff for simplicity.

Setting backoff at `0` effectively disables the mitigation, and gives us safety hatch if something goes wrong.

Current PR deliberately sets backoff at `1000` to simplify testing. The actual value should be chosen by broader experiments.

Additional testing:
 - [x] Linux x86_64 fastdebug, `tier1 tier2 tier3`
 - [x] Linux AArch64 fastdebug, `tier1 tier2 tier3`

-------------

Commit messages:
 - Revert "WIP x86_32"
 - WIP x86_32
 - Revert ARM/PPC/RISC-V/S390 development stubs
 - Development stubs for other arches
 - Touchup flag handling; enable =1000 by default to allow testing
 - Wrinkle: branches destroy condition codes
 - WIP x86_64
 - Cleanups, renames
 - WIP AArch64

Changes: https://git.openjdk.org/jdk/pull/15718/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15718&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8316180
  Stats: 115 lines in 6 files changed: 111 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/15718.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/15718/head:pull/15718

PR: https://git.openjdk.org/jdk/pull/15718


More information about the hotspot-dev mailing list