Integrated: 8315415: OutputAnalyzer.shouldMatchByLine() fails in some cases

Leonid Mesnik lmesnik at openjdk.org
Tue Sep 19 16:36:52 UTC 2023


On Thu, 14 Sep 2023 19:59:53 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

> OutputAnalyzer.shouldMatchByLine(from, to, pattern) 
> treat from and to parameters as patterns and not lines. So it might fail to compile them or work not as expected in some cases.
> 
> I grepped the usage of shouldMatchByLine and stdoutShouldMatchByLine and found that in most cases from/to are set to some regex patterns. So I just updated the names of variables and documentation to explicitly say that from/to are patterns.
> 
> See bugs for details. Tested with tier1 (mostly for validation scripts since no code changes.)

This pull request has now been integrated.

Changeset: 7b1e2bfe
Author:    Leonid Mesnik <lmesnik at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/7b1e2bfe0f805a69b59839b6bf8250b62ea356b8
Stats:     28 lines in 1 file changed: 0 ins; 0 del; 28 mod

8315415: OutputAnalyzer.shouldMatchByLine() fails in some cases

Reviewed-by: dholmes

-------------

PR: https://git.openjdk.org/jdk/pull/15753


More information about the hotspot-dev mailing list