RFR: 8316581: Improve performance of Symbol::print_value_on() [v2]
Thomas Schatzl
tschatzl at openjdk.org
Wed Sep 20 15:43:18 UTC 2023
> Hi all,
>
> please review this (hopefully correct) optimization of `Symbol::print_value_on()`; investigation into class unloading time distribution showed that a lot of time is spent in the `UnloadingEventLog::log()` call (25+%, see CR).
>
> The reason seems to be the use of `outputStream::print()` without any need for formatting.
>
> This seems to decrease time spent in this logging by almost 10x.
>
> Testing: hs_err output seems still be the same, GHA
>
> Thanks,
> Thomas
Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
coleen review
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/15838/files
- new: https://git.openjdk.org/jdk/pull/15838/files/d89cf89c..1ffdce2e
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=15838&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=15838&range=00-01
Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod
Patch: https://git.openjdk.org/jdk/pull/15838.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/15838/head:pull/15838
PR: https://git.openjdk.org/jdk/pull/15838
More information about the hotspot-dev
mailing list