RFR: 8316581: Improve performance of Symbol::print_value_on() [v2]

Aleksey Shipilev shade at openjdk.org
Wed Sep 20 15:53:43 UTC 2023


On Wed, 20 Sep 2023 15:43:18 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Hi all,
>> 
>>   please review this (hopefully correct) optimization of `Symbol::print_value_on()`; investigation into class unloading time distribution showed that a lot of time is spent in the `UnloadingEventLog::log()` call (25+%, see CR).
>> 
>> The reason seems to be the use of `outputStream::print()` without any need for formatting.
>> 
>> This seems to decrease time spent in this logging by almost 10x.
>> 
>> Testing: hs_err output seems still be the same, GHA
>> 
>> Thanks,
>>   Thomas
>
> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
> 
>   coleen review

Marked as reviewed by shade (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/15838#pullrequestreview-1635994358


More information about the hotspot-dev mailing list