RFR: 8316098: Revise signature of numa_get_leaf_groups

Thomas Schatzl tschatzl at openjdk.org
Thu Sep 21 08:35:41 UTC 2023


On Mon, 18 Sep 2023 12:22:11 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

> Simple refactoring to better reflect NUMA node id is non-negative using unsigned type.
> 
> More cleanup can possibly be done to avoid the use of `checked_cast` in `os_windows.cpp`, but since the NUMA code in Windows is unreachable (JDK-8244065), I went to for the smallest diff there in order to avoid adding more untested code.

Lgtm. Please file an RFE for fixing

"More cleanup can possibly be done to avoid the use of checked_cast in os_windows.cpp, but since the NUMA code in Windows is unreachable (JDK-8244065), I went to for the smallest diff there in order to avoid adding more untested code."

and link it to JDK-8244065. Thanks.

-------------

Marked as reviewed by tschatzl (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15786#pullrequestreview-1637241181


More information about the hotspot-dev mailing list