RFR: 8315954: getArgumentValues002.java fails on Graal [v3]

[Doug Simon]

On Thu, 21 Sep 2023 13:18:31 GMT, Frederic Parain <fparain at openjdk.org> wrote:

>> src/hotspot/share/interpreter/oopMapCache.cpp line 616:
>> 
>>> 614:   tmp->fill(method, bci);
>>> 615:   if (tmp->has_valid_mask()) {
>>> 616:     entry->resource_copy(tmp);
>> 
>> If `tmp` is invalid (e.g. oop map was requested for invalid BCI), then `resource_copy` crashes the VM in strange ways since it blindly trusts the mask size to be valid.
>
> This is not the only place where `resource_copy()` is called, could you add an assert in `resource_copy()` itself to check that it is never called with an invalid bci/mask_size.
> Thank you.

Ok, I've added that assertion.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15705#discussion_r1333169517