RFR: 8315954: getArgumentValues002.java fails on Graal [v3]

Frederic Parain fparain at openjdk.org
Thu Sep 21 15:02:45 UTC 2023


On Thu, 21 Sep 2023 14:41:14 GMT, Doug Simon <dnsimon at openjdk.org> wrote:

>> This PR adds `HotSpotResolvedJavaMethod.getOopMapAt` to get the oop map for a method at a given BCI. This is required to do correct clearing of oops at OSR entry points.
>> 
>> As part of this addition, I needed to be able to detect requests for oop maps at invalid BCIs. For this, I added `InterpreterOopMap::has_valid_mask()`. When an oop map computation is requested for an invalid BCI, this method returns false.
>
> Doug Simon has updated the pull request incrementally with one additional commit since the last revision:
> 
>   add assertion to InterpreterOopMap::resource_copy

Runtime changes look good to me. Thank you for the additional assert.

-------------

Marked as reviewed by fparain (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15705#pullrequestreview-1638080188


More information about the hotspot-dev mailing list