RFR: 8314220: Configurable InlineCacheBuffer size [v2]

Dean Long dlong at openjdk.org
Fri Sep 22 23:57:12 UTC 2023


On Wed, 30 Aug 2023 19:24:00 GMT, Ekaterina Vergizova <evergizova at openjdk.org> wrote:

>> InlineCacheBuffer size is currently hardcoded to 10K.
>> This can lead to multiple ICBufferFull safepoints for InlineCacheBuffer cleanup and possible performance degradation.
>> 
>> Added experimental command line option InlineCacheBufferSize with the same default value, allowing it to be configured for performance experiments with ICBufferFull safepoints frequency.
>
> Ekaterina Vergizova has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Changed type, added range check

src/hotspot/share/runtime/flags/jvmFlagConstraintsCompiler.cpp line 443:

> 441: 
> 442: JVMFlag::Error InlineCacheBufferSizeConstraintFunc(int value, bool verbose) {
> 443:   if (value <= 0) {

Shouldn't be needed if the type is unsigned.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15271#discussion_r1334886456


More information about the hotspot-dev mailing list