RFR: 8316746: Top of lock-stack does not match the unlocked object [v2]
Dean Long
dlong at openjdk.org
Tue Sep 26 01:08:24 UTC 2023
On Mon, 25 Sep 2023 21:14:11 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:
>> I think we need to support "Top of lock-stack does not match the unlocked object" and take the slow path. Reason: see JBS issue.
>> Currently only PPC64, x86_64 and aarch64 code. I'd like to get feedback before implementing it for other platforms (needed for all platforms).
>
> Martin Doerr has updated the pull request incrementally with one additional commit since the last revision:
>
> Add x86_64 and aarch64 implementation.
As Roman said, the C2 locks should be balanced, and the lock stack looks correct: nsk.share.jdi.EventHandler.run locks listeners first, then the EventHandler. Maybe something is going wrong in deoptimization? Pushing this change without understanding the cause could make it harder to find the real problem.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/15903#issuecomment-1734677034
More information about the hotspot-dev
mailing list