RFR: 8299915: Remove ArrayAllocatorMallocLimit and associated code [v2]

[David Holmes]

On Mon, 25 Sep 2023 09:20:20 GMT, Afshin Zafari <azafari at openjdk.org> wrote:

>> 1. `ArrayAllocatorMallocLimit` is removed. The test cases that tested it also are removed.
>> 2. `AllocArrayAllocator` instances are replaced with `MallocArrayAllocator`.
>> 3. The signature of `CHeapBitMap::free(ptr, size)` is kept as it is, since it is called in this way from `GrowableBitMap<T>::resize`, where `T` can be also `ArenaBitMap` and `ResourceBitMap`. However, it uses `MallocArrayAllocator::free(ptr)` and ignores the `size`:
>> ```C++
>> void CHeapBitMap::free(bm_word_t* map, idx_t size_in_words) const { 
>>  MallocArrayAllocator<bm_word_t>::free(map);
>> }
>> 
>> ### Test
>> tiers1-4 passed on all platforms.
>
> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
> 
>   other size_t flags than the ArrayAllocatorMallocLimit are used in tests.

test/hotspot/jtreg/serviceability/attach/AttachSetGetFlag.java line 62:

> 60:     // Test a non-manageable size_t flag.
> 61:     // Since it is not manageable, we can't test the setFlag functionality.
> 62:     testGetFlag("StringDeduplicationCleanupDeadMinimum", "128");

A non-experimental flag, like MetaspaceSize, might be better long term in case the experimental flag get removed again.

test/lib-test/jdk/test/whitebox/vm_flags/SizeTTest.java line 38:

> 36: 
> 37: public class SizeTTest {
> 38:     private static final String FLAG_NAME = "StringDeduplicationCleanupDeadMinimum";

Again a non-experimental flag, like MetaspaceSize, might be better here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15859#discussion_r1336545378
PR Review Comment: https://git.openjdk.org/jdk/pull/15859#discussion_r1336546774