RFR: 8316735: Print LockStack in hs_err files [v2]

David Holmes dholmes at openjdk.org
Tue Sep 26 06:30:14 UTC 2023


On Mon, 25 Sep 2023 10:50:45 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> src/hotspot/share/runtime/lockStack.hpp line 33:
>> 
>>> 31: #include "utilities/sizes.hpp"
>>> 32: 
>>> 33: class JavaThread;
>> 
>> Seems an unrelated change.
>
> This is a minor cleanup of the prototypes. lockStack.hpp uses `JavaThread*`, not `Thread*`. Do you prefer not to touch it in this PR?

If it uses `JavaThread` but only had `Thread` then it must be including it some other way, so the prototype seems unnecessary. But okay to leave it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15884#discussion_r1336681164


More information about the hotspot-dev mailing list