RFR: 8315966: Relativize initial_sp in interpreter frames [v2]

Martin Doerr mdoerr at openjdk.org
Tue Sep 26 14:26:17 UTC 2023


On Tue, 26 Sep 2023 11:41:52 GMT, Fredrik Bredberg <fbredberg at openjdk.org> wrote:

>> Relativize initial_sp in interpreter frames.
>> 
>> By changing the "initial_sp" (AKA "monitor_block_top" or "monitors" on PowerPC) member in interpreter frames from being an absolute address into an offset that is relative to the frame pointer, we don't need to change the value as we freeze and thaw frames of virtual threads. This is since we might freeze and thaw from and to different worker threads, so the absolute address to locals might change, but the offset from the frame pointer will be constant.
>> 
>> This subtask only handles relativization of "initial_sp" and "monitor_block_top" since it's the same slot in interpreter frames (roughly the same as "monitors" on PowerPC). Relativization of other interpreter frame members are handled in other subtasks to JDK-8289296.
>> 
>> Tested tier1-tier7 on supported platforms. The rest was sanity tested using Qemu.
>
> Fredrik Bredberg has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Updated after review.

PPC64 part looks great! Thanks!

-------------

Marked as reviewed by mdoerr (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15815#pullrequestreview-1644420114


More information about the hotspot-dev mailing list