RFR: 8316180: Thread-local backoff for secondary_super_cache updates [v6]

Aleksey Shipilev shade at openjdk.org
Wed Sep 27 16:45:07 UTC 2023


> Work in progress, submitting for broader attention.
> 
> See more details in the bug and related issues.
> 
> This is the attempt to mitigate [JDK-8180450](https://bugs.openjdk.org/browse/JDK-8180450), while the more complex fix that would obviate the need for `secondary_super_cache` is being worked out. The goal for this fix is to improve performance in pathological cases, while keeping non-pathological cases out of extra risk, *and* staying simple enough and reliable for backports to currently supported JDK releases.
> 
> This implements the mitigation for AArch64 and x86_64. More platforms can be implemented in this PR, or deferred to later PRs. Port maintainers, feel free to suggest the patches for your arches, I'll be happy to fold them in.
> 
> Note that the code is supposed to be rather compact, because it is inlined in generated code. That is why, for example, we cannot easily do x86_32 version: we need a thread, so the easiest way would be to call into VM. But we cannot that easily: the code blowout would make some forward branches in external code non-short. I think we we cannot implement this mitigation on some architectures, so be it, it would be a sensible tradeoff for simplicity.
> 
> Setting backoff at `0` effectively disables the mitigation, and gives us safety hatch if something goes wrong.
> 
> Current PR deliberately sets backoff at `1000` to simplify testing. The actual value should be chosen by broader experiments.
> 
> Additional testing:
>  - [x] Linux x86_64 fastdebug, `tier1 tier2 tier3`
>  - [x] Linux AArch64 fastdebug, `tier1 tier2 tier3`

Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 16 additional commits since the last revision:

 - Merge branch 'master' into JDK-8316180-backoff-secondary-super
 - Init with backoff right away
 - x86 cleanup
 - Denser AArch64
 - Cleaner AArch64 code
 - Use proper 32-bit stores on AArch64
 - PPC version
 - Revert "WIP x86_32"
   
   This reverts commit dc37d25b5ef232e2c8b0ac9c966c41a1ae3cca82.
 - WIP x86_32
 - Revert ARM/PPC/RISC-V/S390 development stubs
 - ... and 6 more: https://git.openjdk.org/jdk/compare/0bc5653f...bc6964ad

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/15718/files
  - new: https://git.openjdk.org/jdk/pull/15718/files/81a0ddd2..bc6964ad

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=15718&range=05
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15718&range=04-05

  Stats: 71316 lines in 1463 files changed: 25882 ins; 12613 del; 32821 mod
  Patch: https://git.openjdk.org/jdk/pull/15718.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/15718/head:pull/15718

PR: https://git.openjdk.org/jdk/pull/15718


More information about the hotspot-dev mailing list