RFR: 8316180: Thread-local backoff for secondary_super_cache updates [v5]

[Vladimir Ivanov]

On Wed, 27 Sep 2023 17:04:54 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> I referred to default value because in your particular case it controls whether the feature is turned on or off. Calling a feature experimental when it is unconditionally turned on in product builds looks a bit weird, doesn't it?
>
> Well, maybe :) One might ask another question: if I am experimenting with the value of this option, by switching from non-zero default to another non-zero value for performance evaluation in the field, is it really "diagnostic"? I think "experimental" captures the whole thing better. But I can change to diagnostic, if you insist.

A better question to ask is "Why do I have to specify -XX:+UnlockExperimentalVMOptions to turn the feature OFF?". Diagnosing a performance anomaly may involve both turning the logic off or increasing the limit. So, I do think that diagnostic is a better fit here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15718#discussion_r1338970246