RFR: 8316309: AArch64: VMError::print_native_stack() crashes on Java native method frame [v2]

[Patricio Chilano Mateo]

On Fri, 29 Sep 2023 03:49:50 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> Patricio Chilano Mateo has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - add comment to tests
>>  - use driver + @requires vm.flagless
>
> test/hotspot/jtreg/runtime/ErrorHandling/StackWalkNativeToJava.java line 39:
> 
>> 37:  * @requires os.family != "windows"
>> 38:  * @library /test/lib
>> 39:  * @run main/othervm StackWalkNativeToJava
> 
> I think it should be driver instead of main/othervm here.

Fixed.

> test/hotspot/jtreg/runtime/ErrorHandling/StackWalkNativeToJava.java line 67:
> 
>> 65:         commands.add("StackWalkNativeToJava$TestNativeToJavaNative");
>> 66: 
>> 67:         ProcessBuilder pb = ProcessTools.createJavaProcessBuilder(commands);
> 
> The test ignores any external VM flags. Pleas add
> @requires vm.flagless
> to the test header to don't run this test with any additional VM flags

Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15972#discussion_r1341495319
PR Review Comment: https://git.openjdk.org/jdk/pull/15972#discussion_r1341495528