RFR: 8316746: Top of lock-stack does not match the unlocked object [v3]
Dean Long
dlong at openjdk.org
Sat Sep 30 03:09:56 UTC 2023
On Thu, 28 Sep 2023 10:38:52 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:
>> I think we need to support "Top of lock-stack does not match the unlocked object" and take the slow path. Reason: see JBS issue.
>> Currently only PPC64, x86_64 and aarch64 code. I'd like to get feedback before implementing it for other platforms (needed for all platforms).
>
> Martin Doerr has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>
> - Pass may_be_unordered information to lightweight_unlock.
> - Merge remote-tracking branch 'origin' into 8316746_lock_stack
> - Add x86_64 and aarch64 implementation.
> - 8316746: Top of lock-stack does not match the unlocked object
Hmmm, I believe you're right. If only C2 is affected and not C1, then we should fix it in load_interpreter_state(). If C1 is also affected we can fix it in OSR_migration_begin().
-------------
PR Comment: https://git.openjdk.org/jdk/pull/15903#issuecomment-1741641760
More information about the hotspot-dev
mailing list