RFR: 8329083: RISC-V: Update profiles supported on riscv
Fei Yang
fyang at openjdk.org
Thu Apr 4 08:14:09 UTC 2024
On Wed, 3 Apr 2024 10:25:31 GMT, Hamlin Li <mli at openjdk.org> wrote:
> Hi,
> Can you help to review this patch to update vm flags related to riscv profile?
> Thanks
>
> Currently there are vm options like -XX:+UseRVA20U64 and -XX:+UseRVA22U64 on riscv to indicate the supported riscv extension via profiles.
> These profiles should be updated to reflect the full supported extensions and new profile like UseRVA23U64 should be added too.
src/hotspot/cpu/riscv/globals_riscv.hpp line 104:
> 102: product(bool, UseRVC, false, "Use RVC instructions") \
> 103: product(bool, UseRVA22U64, false, EXPERIMENTAL, "Use RVA22U64 profile") \
> 104: product(bool, UseRVA23U64, false, EXPERIMENTAL, "Use RVA23U64 profile") \
Can we group the three RV profile-related options together?
src/hotspot/cpu/riscv/vm_version_riscv.hpp line 191:
> 189: #define RV_USE_RVA22U64 \
> 190: RV_ENABLE_EXTENSION(UseRVC) \
> 191: RV_ENABLE_EXTENSION(UseRVV) \
Note that V was optional in RVA22U64.
src/hotspot/cpu/riscv/vm_version_riscv.hpp line 208:
> 206: RV_ENABLE_EXTENSION(UseRVC) \
> 207: RV_ENABLE_EXTENSION(UseRVV) \
> 208: RV_ENABLE_EXTENSION(UseZacas) \
Zacas is RVA23U64 Optional Extension.
src/hotspot/cpu/riscv/vm_version_riscv.hpp line 219:
> 217: RV_ENABLE_EXTENSION(UseZicboz) \
> 218: RV_ENABLE_EXTENSION(UseZihintpause) \
> 219: RV_ENABLE_EXTENSION(UseZvfh) \
Zvfh is RVA23U64 Optional Extension too.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18599#discussion_r1551137496
PR Review Comment: https://git.openjdk.org/jdk/pull/18599#discussion_r1551130158
PR Review Comment: https://git.openjdk.org/jdk/pull/18599#discussion_r1551134056
PR Review Comment: https://git.openjdk.org/jdk/pull/18599#discussion_r1551136167
More information about the hotspot-dev
mailing list