RFR: 8310513: [s390x] Intrinsify recursive ObjectMonitor locking

Amit Kumar amitkumar at openjdk.org
Fri Apr 5 04:04:32 UTC 2024


On Wed, 6 Mar 2024 16:34:26 GMT, Lutz Schmidt <lucy at openjdk.org> wrote:

>> src/hotspot/cpu/s390/macroAssembler_s390.cpp line 3207:
>> 
>>> 3205: 
>>> 3206:   if (DiagnoseSyncOnValueBasedClasses != 0) {
>>> 3207:     load_klass(Z_R1_scratch, oop);
>> 
>> @RealLucy if we use `temp` here instead of Z_R1, do you think there will be issues ? It seems temp is free at this point.
>
> Using temp here actually is a good idea. As you know, using the scratch registers (Z_R0 and Z_R1) across calls is risky. You need to know exactly if they are used as scratch further down the call hierarchy.

done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17975#discussion_r1515391375


More information about the hotspot-dev mailing list