RFR: 8312132: Add tracking of multiple address spaces in NMT [v5]

Johan Sjölen jsjolen at openjdk.org
Sat Apr 6 22:10:09 UTC 2024


On Fri, 22 Mar 2024 13:19:45 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Include os.inline.hpp
>
> src/hotspot/share/nmt/nmtTreap.hpp line 54:
> 
>> 52:   uint64_t _priority;
>> 53:   K _key;
>> 54:   V _value;
> 
> Should both key and value be const? After all, you don't want to modify either after the node was added to the tree.

Value should not be const, but key should be.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18289#discussion_r1554720882


More information about the hotspot-dev mailing list