RFR: 8311248: Refactor CodeCache::initialize_heaps to simplify adding new CodeCache segments [v12]
Tobias Hartmann
thartmann at openjdk.org
Mon Apr 8 06:49:10 UTC 2024
On Wed, 3 Apr 2024 16:47:32 GMT, Boris Ulasevich <bulasevich at openjdk.org> wrote:
>> These changes clean up the logic and the code of allocating codecache segments and add more testing of it, to open a door for further optimization of code cache segmentation. The goal was to keep the behavior as close to the existing behavior as possible, even if it's not quite logical.
>>
>> Also, these changes better account for alignment - PrintFlagsFinal shows the final aligned segment sizes, and the segments fill the ReservedCodeCacheSize without gaps caused by alignment.
>
> Boris Ulasevich has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
>
> 8311248: Refactor CodeCache::initialize_heaps to simplify adding new CodeCache segments
Looks good to me.
-------------
Marked as reviewed by thartmann (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/17244#pullrequestreview-1985564573
More information about the hotspot-dev
mailing list