RFR: 8327743: JVM crash in hotspot/share/runtime/javaThread.cpp - failed: held monitor count should be equal to jni: 0 != 1 [v2]

David Holmes dholmes at openjdk.org
Mon Apr 8 12:35:44 UTC 2024


On Mon, 8 Apr 2024 11:56:33 GMT, Fredrik Bredberg <fbredberg at openjdk.org> wrote:

>> David Holmes has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - s/lw/lwu to zero extend flags value
>>  - s/lwz/ld/
>
> src/hotspot/cpu/ppc/sharedRuntime_ppc.cpp line 1666:
> 
>> 1664:     Label L_no_warn;
>> 1665:     __ lwz(R0, in_bytes(JavaThread::jni_monitor_count_offset()), R16_thread);
>> 1666:     __ cmpwi(CCR0, R0, 0);
> 
> Change to:
> 
>     __ ld(R0, in_bytes(JavaThread::jni_monitor_count_offset()), R16_thread);
>     __ cmpdi(CCR0, R0, 0);
> 
> Since `_jni_monitor_count` is a double word on PPC64.

Fixed - there and elsewhere. Thanks

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18445#discussion_r1555728171


More information about the hotspot-dev mailing list