RFR: 8327743: JVM crash in hotspot/share/runtime/javaThread.cpp - failed: held monitor count should be equal to jni: 0 != 1 [v2]

[Fredrik Bredberg]

On Mon, 8 Apr 2024 12:24:30 GMT, Robbin Ehn <rehn at openjdk.org> wrote:

>> src/hotspot/cpu/riscv/sharedRuntime_riscv.cpp line 912:
>> 
>>> 910:     // Check if this is a virtual thread continuation
>>> 911:     Label L_skip_vthread_code;
>>> 912:     __ lw(t0, Address(sp, ContinuationEntry::flags_offset()));
>> 
>> @fbredber : Nit: maybe it's better to use `lwu` here instead of `lw` to load the 32-bit flags? `lw` would do sign-extension for the upper 32 bits which I don't think is wanted in case when we have more meaningful bits in flags. While `lwu` simply zeros the upper 32 bits.
>
> Good catch, thanks!

I agree. Sorry, my bad.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18445#discussion_r1555735361