RFR: 8329488: Move OopStorage code from safepoint cleanup and remove safepoint cleanup code
Coleen Phillimore
coleenp at openjdk.org
Mon Apr 8 16:51:58 UTC 2024
On Mon, 8 Apr 2024 13:54:13 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> Hm, with the change to `has_cleanup_work_and_reset` this will result in the service thread deleting
>> no more than "work limit" blocks per "defer period". Maybe this should reset the "permit time" too,
>> so that it _does_ cause the ServiceThread to loop.
>
> The ServiceThread loops because it has a fixed wait timeout now. It won't process these every time it's notified which can be more frequent. This comment seems to say that there's more work, so do it next time. I guess resetting the permit time to zero would prevent these cleanups from getting behind. Are there tests for this condition?
If you can't delete the last block, you don't really want the service thread to try to clean up right away though? Only if you hit the limit of blocks to delete?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18375#discussion_r1555897504
More information about the hotspot-dev
mailing list