RFR: 8310513: [s390x] Intrinsify recursive ObjectMonitor locking [v2]

Lutz Schmidt lucy at openjdk.org
Mon Apr 8 17:09:13 UTC 2024


On Mon, 8 Apr 2024 16:28:38 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

>> s390 implementation of [JDK-8277180](https://bugs.openjdk.org/browse/JDK-8277180). PPC implementation for the same: https://github.com/openjdk/jdk/pull/7305
>> 
>> I had tested `tier1` on `fastdebug`, `release` vm. 
>> 
>> BenchMarking: 
>> 
>> 
>> ./build/linux-s390x-server-release/jdk/bin/java -Xms4g -Xmx4g -jar dacapo-9.12-MR1-bach.jar h2 -s huge -t 1 -n 1
>> 
>> without patch: 
>> ===== DaCapo 9.12-MR1 h2 PASSED in 223023 msec =====
>> ===== DaCapo 9.12-MR1 h2 PASSED in 225686 msec =====
>> ===== DaCapo 9.12-MR1 h2 PASSED in 219824 msec =====
>> ===== DaCapo 9.12-MR1 h2 PASSED in 226719 msec =====
>> 
>> 
>> 
>> with patch: 
>> ===== DaCapo 9.12-MR1 h2 PASSED in 167816 msec =====
>> ===== DaCapo 9.12-MR1 h2 PASSED in 174368 msec =====
>> ===== DaCapo 9.12-MR1 h2 PASSED in 170517 msec =====
>> ===== DaCapo 9.12-MR1 h2 PASSED in 169349 msec =====
>
> Amit Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   suggestion from Lutz

LGTM.
Reviewed, provided GHA find no errors.

-------------

Marked as reviewed by lucy (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17975#pullrequestreview-1986981203


More information about the hotspot-dev mailing list