RFR: 8327743: JVM crash in hotspot/share/runtime/javaThread.cpp - failed: held monitor count should be equal to jni: 0 != 1 [v2]

Dean Long dlong at openjdk.org
Mon Apr 8 21:13:16 UTC 2024


On Mon, 8 Apr 2024 21:10:04 GMT, Dean Long <dlong at openjdk.org> wrote:

>> David Holmes has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - s/lw/lwu to zero extend flags value
>>  - s/lwz/ld/
>
> src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp line 1052:
> 
>> 1050:     Label L_no_warn;
>> 1051:     __ ldr(rscratch1, Address(rthread, JavaThread::jni_monitor_count_offset()));
>> 1052:     __ cbz(rscratch1, L_no_warn);
> 
> Suggestion:
> 
>     __ cbz(rscratch1, L_skip_vthread_code);

Same for other ports.  If the count is already 0, no need to store 0 below.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18445#discussion_r1556434268


More information about the hotspot-dev mailing list