RFR: 8310513: [s390x] Intrinsify recursive ObjectMonitor locking [v2]

Amit Kumar amitkumar at openjdk.org
Tue Apr 9 13:14:27 UTC 2024


On Tue, 9 Apr 2024 10:37:36 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> Amit Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   suggestion from Lutz
>
> src/hotspot/cpu/s390/macroAssembler_s390.cpp line 3274:
> 
>> 3272:   // Otherwise, register zero is filled with the current owner.
>> 3273:   z_lghi(zero, 0);
>> 3274:   z_csg(zero, Z_thread, OM_OFFSET_NO_MONITOR_VALUE_TAG(owner), monitor_tagged);
> 
> May be a bit confusing that `zero` contains the owner, but I can live with it.

I have updated the comment, but I don't have better name in mind as of now. `zero_or_owner` might make it worse.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17975#discussion_r1557607131


More information about the hotspot-dev mailing list