RFR: 8329488: Move OopStorage code from safepoint cleanup and remove safepoint cleanup code [v2]
Coleen Phillimore
coleenp at openjdk.org
Tue Apr 9 13:56:28 UTC 2024
On Tue, 9 Apr 2024 06:53:10 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Some comment cleanups from Kim.
>
> src/hotspot/share/runtime/globals.hpp line 1288:
>
>> 1286: "Wake the ServiceThread to do periodic cleanup checks" \
>> 1287: "(0 means none)") \
>> 1288: range(0, max_jint) \
>
> The time unit needs to be mentioned - I assume it is ms?
Yes it is ms, like guaranteed safepoint interval, actually PlatformMonitor.lock units, which is ms. I wonder if this is a useful diagnostic option though. Maybe we shouldn't have it?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18375#discussion_r1557670555
More information about the hotspot-dev
mailing list