RFR: 8312132: Add tracking of multiple address spaces in NMT [v29]

Johan Sjölen jsjolen at openjdk.org
Tue Apr 9 14:37:26 UTC 2024


On Tue, 9 Apr 2024 13:41:35 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> > Right, the refactoring to remove the `friend` declaration has completely fumbled the code. I'll probably force a revert on this to the state before that or do a git bisect to find the bugs. Right now the code is basically borked.
> > Last good hash: [7445999](https://github.com/openjdk/jdk/commit/7445999ee296872320f91146e1004026ba1133c7)
> 
> God, sorry. Do as you think is best.
> 
> I plan to look at this PR, but probably it will not be this week.
> 
> Love your commit messages btw.

Nah, it's alright. It was literally that my getter `right()` returned `_left`, this was of course impossible for me to see after staring at the code for too long. Fixing that did lead to a good commit message, I'm happy you appreciate them :-).

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18289#issuecomment-2045331994


More information about the hotspot-dev mailing list