RFR: 8327743: JVM crash in hotspot/share/runtime/javaThread.cpp - failed: held monitor count should be equal to jni: 0 != 1 [v4]

[David Holmes]

On Tue, 9 Apr 2024 20:44:53 GMT, Patricio Chilano Mateo <pchilanomate at openjdk.org> wrote:

>> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Avoid unnecessary store when count was already zero.
>
> Looks good to me, thanks for working this one out David.

Thanks for the review @pchilano .

> test/hotspot/jtreg/runtime/vthread/JNIMonitor/JNIMonitor.java line 117:
> 
>> 115:             // The following is a hack to trick the pool worker threads into terminating
>> 116:             // after one second (default keep-alive / parallelism).
>> 117:             "-Djdk.virtualThreadScheduler.parallelism=30",
> 
> Leftover from old testing?

Yep - well spotted. Fixed. Also fixed incorrect comment about the add-opens.

> test/hotspot/jtreg/runtime/vthread/JNIMonitor/JNIMonitor.java line 202:
> 
>> 200: 
>> 201:         // This gives us a way to control the scheduler used for our virtual threads. The test
>> 202:         // only works as intended then the virtual threads run on the same carrier thread (as
> 
> Nit: s/then/when

Fixed

> test/hotspot/jtreg/runtime/vthread/JNIMonitor/JNIMonitor.java line 203:
> 
>> 201:         // This gives us a way to control the scheduler used for our virtual threads. The test
>> 202:         // only works as intended then the virtual threads run on the same carrier thread (as
>> 203:         // that carrier maintains ownership of the monitor if the virtual thread fails to unlock it.
> 
> Nit: Missing ')'.

Fixed

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18445#issuecomment-2046101799
PR Review Comment: https://git.openjdk.org/jdk/pull/18445#discussion_r1558332614
PR Review Comment: https://git.openjdk.org/jdk/pull/18445#discussion_r1558333784
PR Review Comment: https://git.openjdk.org/jdk/pull/18445#discussion_r1558333911