RFR: 8329488: Move OopStorage code from safepoint cleanup and remove safepoint cleanup code [v3]

Erik Österlund eosterlund at openjdk.org
Wed Apr 10 05:22:00 UTC 2024


On Wed, 10 Apr 2024 02:41:01 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Ok, I think I restated what Kim said.
>
>> The only reason for the store-release is because we use load-acquire and it's consistent.
> 
> So why do we use load-acquire? That is typically to pair with a store-release. We only need release semantics if someone seeing this store must see previous stores as well.

Ah, okay. Then this seems fine. Maybe tweak or remove the comment to reflect this conversation. It seems to be saying the opposite of what it is doing.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18375#discussion_r1558857602


More information about the hotspot-dev mailing list