RFR: JDK-8329605: hs errfile generic events - introduce sections for Frequent/NotFrequent Events [v3]

[Matthias Baesken]

On Tue, 9 Apr 2024 07:31:23 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> Currently the 'generic' hs_errfile Events message log (filled  by Events::log) is rather flooded by messages for memory protection operations. Those seem to occur quite often and move out other less frequent events, because the number of entries in the log is limited.
>> It might be better to separate the frequent and less frequent events into 2 sections. The memory protection events would go into the frequent events section.
>> The mentioned memory protection operations related entries look like this :
>> Event: 0.178 Protecting memory [0x000000016ebf0000,0x000000016ebfc000] with protection modes 0
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
> 
>   adjust typo

Hi Lucy, thanks for the review !  May I have a second one please ?

> FWIW, I think I am of the opposite opinion. I find it very helpful to have the events separated into distinct sections and wouldn't 
> want them all combined into one big section.

Yeah, both approaches (one single big log, or multiple ones) have pros and cons.
But having multiple logs is a long established HS approach so I do not think that it is in scope of this PR to change the established approach.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18626#issuecomment-2046684451